Skip to content

starknet_os: define sha256 batch resources constants#14140

Open
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_keccakfrom
05-23-starknet_os_define_sha256_batch_resources_constants
Open

starknet_os: define sha256 batch resources constants#14140
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_keccakfrom
05-23-starknet_os_define_sha256_batch_resources_constants

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Test-only resource accounting and constants; no production OS or fee logic paths changed in this diff.

Overview
Adds published ExecutionResources constants for the Starknet OS SHA-256 batch phase: a per-round linear component (steps + bitwise/range_check builtins) and a small constant overhead, derived from BUILTIN_INSTANCE_SIZES.

Introduces an integration test that runs the OS Cairo entrypoint finalize_sha256 on synthetic instance data (with Rust sha2 for expected output states), samples VM resources at two block counts one round apart, and asserts the measured linear and constant factors match those constants.

Reviewed by Cursor Bugbot for commit 062b998. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_define_sha256_batch_resources_constants branch from e94b0c7 to 908973c Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-23-starknet_os_os_resources_test_-_add_keccak to graphite-base/14140 May 25, 2026 09:48
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_define_sha256_batch_resources_constants branch from 908973c to fd6b95e Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14140 to 05-23-starknet_os_os_resources_test_-_add_keccak May 28, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants